Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(osp): applied regex validation on uniqueIds param #1163

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(osp): applied regex validation on uniqueIds param #1163

wants to merge 5 commits into from

Conversation

tfjanjua
Copy link
Contributor

Description

Applied one more validation on uniqueIds param through regex.

Why

Currently, request is being validated with invalid data e.g: "VAT ID" --> “value“ : “XYZ“

image

Issue

Ref: #1157

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua requested review from Phil91, dhiren-singh-007 and ntruchsess and removed request for dhiren-singh-007 November 19, 2024 11:06
@tfjanjua tfjanjua self-assigned this Nov 19, 2024
@tfjanjua tfjanjua added the bug Something isn't working label Nov 19, 2024
@ntruchsess ntruchsess linked an issue Nov 19, 2024 that may be closed by this pull request
OSP | Regex validation needs to be applied #1157
Open
@ntruchsess ntruchsess self-assigned this Nov 19, 2024
@tfjanjua tfjanjua requested a review from ntruchsess November 22, 2024 15:39
@evegufy evegufy added this to the Release 25.03 milestone Dec 13, 2024
@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

please take care of codeql finding

@Phil91
Copy link
Member

Phil91 commented Dec 13, 2024

changes looks fine, after the fix of the codeQl finding we can merge the pr imo

@tfjanjua
Copy link
Contributor Author

@evegufy | @Phil91
codeql findings has been resolved.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Awaiting requested review from Phil91

@dhiren-singh-007 dhiren-singh-007 Awaiting requested review from dhiren-singh-007

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Requested changes must be addressed to merge this pull request.

Assignees

@ntruchsess ntruchsess

@tfjanjua tfjanjua

Labels
bug Something isn't working
Projects
Portal
Status: IN REVIEW
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.

OSP | Regex validation needs to be applied
4 participants
@tfjanjua @evegufy @Phil91 @ntruchsess